Skip to content

Engine: Add more tests for left and right ERB Trimming#650

Merged
marcoroth merged 2 commits into
mainfrom
engine-trim-support
Dec 3, 2025
Merged

Engine: Add more tests for left and right ERB Trimming#650
marcoroth merged 2 commits into
mainfrom
engine-trim-support

Conversation

@marcoroth

@marcoroth marcoroth commented Oct 15, 2025

Copy link
Copy Markdown
Owner

More tests for #649 and #841.

@marcoroth marcoroth added feature New feature or request engine labels Oct 15, 2025
marcoroth added a commit that referenced this pull request Nov 11, 2025
This pull request implements support for left trimming ` <%-` and right
trimming `-%>` in the `Herb::Engine`. This should now more closely match
the compiled template `Erubi::Engine` produces and renders.

Resolves #649
Enables #650
@pkg-pr-new

pkg-pr-new Bot commented Dec 3, 2025

Copy link
Copy Markdown
npx https://pkg.pr.new/@herb-tools/formatter@650
npx https://pkg.pr.new/@herb-tools/language-server@650
npx https://pkg.pr.new/@herb-tools/linter@650

commit: 350c4ca

@github-actions

github-actions Bot commented Dec 3, 2025

Copy link
Copy Markdown

🌿 Interactive Playground and Documentation Preview

A preview deployment has been built for this pull request. Try out the changes live in the interactive playground:


🌱 Grown from commit 350c4ca


✅ Preview deployment has been cleaned up.

@marcoroth marcoroth changed the title Engine: Support left and right ERB Trimming Engine: Add more tests for left and right ERB Trimming Dec 3, 2025
@marcoroth marcoroth marked this pull request as ready for review December 3, 2025 18:12
@marcoroth marcoroth merged commit 1429d15 into main Dec 3, 2025
20 checks passed
@marcoroth marcoroth deleted the engine-trim-support branch December 3, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant